Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add magazine wells for GM CDLC #1538

Merged
merged 11 commits into from
Sep 13, 2023
Merged

Add magazine wells for GM CDLC #1538

merged 11 commits into from
Sep 13, 2023

Conversation

Dahlgren
Copy link
Contributor

When merged this pull request will:

  • Enable GM weapons to use magazines implementing CBA magazine wells
  • Enable GM magazines to be used in other weapons implementing CBA magazine wells

@Dahlgren
Copy link
Contributor Author

Might be worth moving the magazine well definitions over into the conditional GM config to avoid cluttering config with invalid magazine definitions when GM isn't loaded

@Dahlgren Dahlgren mentioned this pull request Mar 23, 2022
Merged
@jonpas jonpas added this to the 3.16.0 milestone Sep 6, 2023
@jonpas jonpas marked this pull request as ready for review September 7, 2023 17:37
@jonpas jonpas merged commit 0132738 into CBATeam:master Sep 13, 2023
3 of 4 checks passed
@Dahlgren Dahlgren deleted the feature/gm-magazine-wells branch September 17, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas left review comments

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
2.14 Enhancement
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Dahlgren @jonpas @PabstMirror